| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "david(at)pgmasters(dot)net" <david(at)pgmasters(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: allow online change primary_conninfo |
| Date: | 2020-03-17 16:53:15 |
| Message-ID: | 3186431584462769@iva6-22e79380f52c.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
Sorry for late replies.
> Yes. In my opinion, patch 0002 should not change the GUC mode of
> wal_receiver_create_temp_slot as the discussion here is about
> primary_conninfo, even if both may share some logic regarding WAL
> receiver shutdown and its restart triggered by the startup process.
Ok, I removed related changes from main patch. Along with minor merge conflict.
> Patch 0001 has actually been presented on this thread first:
> https://www.postgresql.org/message-id/753391579708726@iva3-77ae5995f07f.qloud-c.yandex.net
> And there is an independent patch registered in this CF:
> https://commitfest.postgresql.org/27/2456/
Yep, 0001 is separate patch. I will post copy of this patch here to make cfbot works. Main patch 0002 requires resetting of is_temp_slot in RequestXLogStreaming to works properly.
> Should we add patch 0001 as an open item for v13 as there is a risk of
> forgetting this issue?
I think yes.
Well, it seems better to move this patch to next commitfest?
regards, Sergei
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-v3-change-wal_receiver_create_temp_slot.patch | text/x-diff | 9.4 KB |
| 0002_v9_allow_reload_walreceiver_conninfo.patch | text/x-diff | 13.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-03-17 17:05:17 | Re: PATCH: add support for IN and @> in functional-dependency statistics use |
| Previous Message | Ashutosh Bapat | 2020-03-17 16:41:43 | Re: BEFORE ROW triggers for partitioned tables |