Re: Catalog domain not-null constraints

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: jian he <jian(dot)universality(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: Catalog domain not-null constraints
Date: 2024-03-20 09:43:47
Message-ID: 318412bd-9691-4967-8c1b-9c4894fa69a6@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.03.24 10:57, jian he wrote:
> this new syntax need to be added into the alter_domain.sgml's synopsis and also
> need an explanation varlistentry?

The ALTER DOMAIN reference page refers to CREATE DOMAIN about the
details of the constraint syntax. I believe this is still accurate. We
could add more detail locally on the ALTER DOMAIN page, but that is not
this patch's job. For example, the details of CHECK constraints are
also not shown on the ALTER DOMAIN page right now.

> + false, /* connoinherit */
> + false, /* conwithoutoverlaps */
> + false); /* is_internal */
>
> /* conwithoutoverlaps */
> should be
> /* conperiod */

Good catch, thanks.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shubham Khanna 2024-03-20 10:16:13 Re: speed up a logical replica setup
Previous Message Peter Eisentraut 2024-03-20 09:41:33 Re: Catalog domain not-null constraints