Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Степан Перлов <stepanperlov(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp
Date: 2015-10-19 21:57:40
Message-ID: 31798.1445291860@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
> On 2015-10-19 17:31, Tom Lane wrote:
>> So I see. Apparently we broke something during 9.4 devel.

> Yeah it's the commits c00c3249e and bda76c1c8. First one changed the
> output to not use to_char so that we could produce correct ISO timestamp
> and disallowed the infinity altogether, the second added custom handling
> for infinity, but the code does not differentiate between negative and
> positive infinity. I think the json code does not need to have custom
> handling of infinity but could just call the EncodeSpecialTimestamp() if
> it was exported from the timestamp module.

Meh. We'd have to change its API too, because it is expecting to print
into a fixed buffer. I think probably easier to just duplicate the check.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Scott Mead 2015-10-19 22:26:35 Re: [BUGS] postgresql table data control
Previous Message David G. Johnston 2015-10-19 18:01:41 Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp