Re: pgsql: Extend & revamp pg_bswap.h infrastructure.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Extend & revamp pg_bswap.h infrastructure.
Date: 2017-09-30 16:17:06
Message-ID: 31674.1506788226@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Extend & revamp pg_bswap.h infrastructure.

Hm, what is the point of this in pg_bswap.h:

+#ifdef _MSC_VER
+#include <stdlib.h>
+#endif

c.h will already have included <stdlib.h>. There might be some
value in this if we anticipated allowing freestanding use of this
header, but that won't happen because it depends on configure symbols.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-30 16:20:40 Re: pgsql: Extend & revamp pg_bswap.h infrastructure.
Previous Message Andres Freund 2017-09-30 00:41:50 pgsql: Fix copy & pasto in 510b8cbff15f.