| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Date: | 2017-05-21 14:12:20 |
| Message-ID: | 31643.1495375940@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
> On 2017-05-21 03:00, Tom Lane wrote:
>> I wrote:
>>> Also, I found two places where an overlength comment line is simply busted
>>> altogether --- notice that a character is missing at the split point:
>> I found the cause of that: you need to apply this patch:
> I have been analyzing this and came to different conclusions.
Well, the code as it stands breaks those two comments (and a third one
I'd failed to notice before). With the patch I propose, the only changes
are that those comments are left unmolested. So even aside from the
fact that this code is visibly unsafe, it does correspond to the symptom.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-05-21 15:14:34 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Previous Message | Piotr Stefaniak | 2017-05-21 05:36:31 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-05-21 15:14:34 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Previous Message | MauMau | 2017-05-21 10:45:04 | Re: [Q] When should I use reg* types instead of oid in the system catalog? |