| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, nikhil raj <nikhilraj474(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables. |
| Date: | 2024-08-27 23:15:21 |
| Message-ID: | 3156371.1724800521@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Wed, 28 Aug 2024 at 09:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The other problem with this is that it breaks one test case in
>> memoize.sql: a query that formerly generated a memoize plan
>> now does not use memoize. I am not sure why not --- does that
>> mean anything to you?
> The reason it works in master is that get_memoize_path() calls
> extract_lateral_vars_from_PHVs() and finds PlaceHolderVars to use as
> the Memoize keys. With your patch PlannerInfo.placeholder_list is
> empty.
That seems like a pretty fishy way to do it. Are you saying that
Memoize is never applicable if there aren't outer joins in the
query? Without OJs there probably won't be any PHVs.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-08-27 23:37:56 | Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables. |
| Previous Message | David Rowley | 2024-08-27 23:03:08 | Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2024-08-27 23:17:45 | Re: PoC: prefetching data between executor nodes (e.g. nestloop + indexscan) |
| Previous Message | David Rowley | 2024-08-27 23:03:08 | Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables. |