Re: Commitfest problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Commitfest problems
Date: 2014-12-11 22:12:31
Message-ID: 31541.1418335951@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Josh Berkus <josh(at)agliodbs(dot)com> writes:
> Well, the CF process was added for 2 reasons:

> 1) We were losing track of some patches until integration time, when
> Bruce suddently found them in the -hackers archives.

> 2) In order to give the senior committers some time *off* from reviewing
> other people's patches. The idea was to spend 3 weeks or so intensively
> reviewing others' patches, and then to have a month (or more) *off* from
> working on anything but your own stuff.

Right; I was in the middle of composing words to the same effect when
this arrived.

> While the CFs are still doing (1), support for (2) ended sometime in the
> 9.3 development cycle. Partly this is because current CFMs are not
> permitted to take authoritative steps to ensure that the CF ends on
> time, and partly it's because of the increase in big complicated patches
> which just don't fit into the CF cycle.

I don't see why you think CFMs are not "permitted" to close out a CF
when they want to. At least some of the fests have been closed out per
calendar schedule, punting unprocessed patches to the next fest. We've
certainly utterly failed to do that since August, but I think that's
mismanagement.

> Speaking as the originator of commitfests, they were *always* intended
> to be a temporary measure, a step on the way to something else like
> continuous integration.

Really? How would that address (2)? And please note that part of the
problem we're having right now is that senior people are rebelling
against no longer having any agreed-on time off. IMV, goal (2) is
not optional; if you try to force people into continuous review work,
you'll just lose them completely.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-12-11 22:27:17 Re: Commitfest problems
Previous Message Peter Geoghegan 2014-12-11 22:05:07 Re: Commitfest problems