Re: relcache reference leak on refresh materialized view concurrently

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: yamamoto(at)valinux(dot)co(dot)jp (YAMAMOTO Takashi)
Cc: pgsql-bugs(at)postgresql(dot)org, kgrittn(at)postgresql(dot)org
Subject: Re: relcache reference leak on refresh materialized view concurrently
Date: 2014-03-17 20:00:07
Message-ID: 31494.1395086407@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

yamamoto(at)valinux(dot)co(dot)jp (YAMAMOTO Takashi) writes:
> the following patch fixes missing index_close in case
> the mv has non-unique indexes.

Hm ... I see the leak, I think, but isn't this an extraordinarily
complex patch? Looks like adding

else
{
index_close(indexRel, NoLock);
}

at the bottom of the "if" would also fix the problem, and would be
far easier to verify.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Noah Misch 2014-03-17 21:32:02 Re: BUG #9472: pg_dumpall fails with "unrecognized node type: 650"
Previous Message Jeff Frost 2014-03-17 19:01:24 Re: BUG #9606: pg_class relhaspkey column not updated on removal of primary key