Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Date: 2016-04-08 21:48:50
Message-ID: 31479.1460152130@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 01/22/2016 03:46 PM, Tom Lane wrote:
>> Add trigonometric functions that work in degrees.

> I have a host here that is having regression test failures from this commit:

> --- src/test/regress/expected/float8.out
> +++ src/test/regress/results/float8.out
> @@ -490,9 +490,9 @@
> x | asind | acosd | atand
> ------+-------+-------+-------
> -1 | -90 | 180 | -45
> - -0.5 | -30 | 120 |
> + -0.5 | | 120 |
> 0 | 0 | 90 | 0
> - 0.5 | 30 | 60 |
> + 0.5 | | 60 |
> 1 | 90 | 0 | 45
> (5 rows)

BTW ... looking closer at that, it appears to show asind(-0.5) and
asind(0.5) returning NULL. Which makes no sense at all, because
there is no provision in dasind() for returning a null, regardless
of the input value.

So I'm pretty baffled. Maybe you could step through this and figure
out where it's going off the rails?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-08 21:52:19 Re: pgsql: Add the "snapshot too old" feature
Previous Message Andres Freund 2016-04-08 21:27:56 pgsql: Expose more out/readfuncs support functions.

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-08 21:52:19 Re: pgsql: Add the "snapshot too old" feature
Previous Message Stephen Frost 2016-04-08 21:45:11 Re: Default Roles (was: Additional role attributes)