Re: Segmentation fault with postgres -C external_pid_file

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Thu, Jun 16, 2016 at 3:40 AM, Jehan-Guillaume de Rorthais
> <jgdr(at)dalibo(dot)com> wrote:
>> I just found that the following command always produce a segmentation fault
>> when external_pid_file is kept commented:
>> $ postgres -C external_pid_file
>> Segmentation fault (core dumped)

> Confirmed. puts() would print (null) on OSX even if that's not
> mentioned in the standard, and Linux would just segfault on it.

Right, this is going to be platform-specific behavior.

> So instead of your patch, I think that we'd rather just change
> PostmasterMain() so as it outputs something useful to the user in case
> of a NULL value, like that:

Agreed, fixing the -C code seems much less likely to have unexpected
side-effects than changing default values. Will push this in a bit.

regards, tom lane