Re: vacuum_truncate configuration parameter and isset_offset

В письме от понедельник, 24 марта 2025 г. 17:43:38 MSK пользователь Nathan
Bossart написал:

> * vacuum_truncate is already a Boolean reloption,
Yes, I guess schema update would be best solution here.

> so switching it to an
> enum would require enumerating all possible values accepted by
> parse_bool(), which has the following comment:
>
> /*
> * Try to interpret value as boolean value. Valid values are: true,
> * false, yes, no, on, off, 1, 0; as well as unique prefixes thereof.
> * If the string parses okay, return true, else false.
> * If okay and result is not NULL, return the value in *result.
> */

We already do it for some option. May be we need more generic solution, but
boolean should remain boolean, with only two possible values.

> * I wasn't sure whether it would be better to expose this third "unset"
> value or to make it hidden and for internal use only.
If you hide something from user, you will confuse him. If the solution is
more explicit, then it is more easy to use it, and understand it. If something
is implying (like deleted option means third value), then there would be
confusion. Please do not do that.

--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su