| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() |
| Date: | 2018-06-15 14:25:27 |
| Message-ID: | 31412.1529072727@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> On Fri, Jun 15, 2018 at 4:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Maybe I just lack caffeine, but I don't see anything especially
>> wrong with what you wrote?
> It doesn't contain something particular wrong, but it's just badly
> formatted. As I can see, we're keeping lines in commit messages no
> longer than 80 characters when possible. I've commit message with 158
> characters line for no reason. It was just because I wrote this
> commit message with word wrapping enabled.
Ah, it wrapped in my mail app so I didn't notice.
FWIW, I actually try to keep commit log lines to 75 characters, because
that's what displays nicely in "git log". Links such as Discussion:
tags tend to run over, but there's little to be done about that as long
as gmail insists on such ridiculously long message IDs :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-06-15 14:43:15 | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() |
| Previous Message | Alexander Korotkov | 2018-06-15 14:16:04 | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() |