| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: lwlocknames.h beautification attempt |
| Date: | 2025-03-02 07:00:33 |
| Message-ID: | 3131835.1740898833@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
> On Sat, Mar 1, 2025 at 10:26 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> This looks reasonably in line with project style ...
> Should I create a commitfest entry for this patch, or is it
> uncontroversial enough and small enough to not warrant that?
The controversy would be more about whether it's worth bothering
with. In the past we've taken some care to ensure that generated
files would pass pgindent's ideas of correct formatting, but
not more than that. AFAICT from some quick tests, pgindent has
no opinions about layout of #define lines.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2025-03-02 07:40:11 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | Gurjeet Singh | 2025-03-02 06:35:12 | Re: lwlocknames.h beautification attempt |