| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, HeikkiLinnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Trouble with hashagg spill I/O pattern and costing |
| Date: | 2020-05-29 20:12:40 |
| Message-ID: | 312bf7eb53b0b9f953e4eb0c704ed4f2121bce4d.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2020-05-29 at 15:04 +0200, Tomas Vondra wrote:
> Ah, right. Yeah, we only need to check for AGG_HASH here. Moreover,
> AGG_MIXED probably does not need the tlist tweak, because the input
> should be pre-sorted as with AGG_SORTED.
>
> And we should probably do similar check in the
> create_groupinsets_path,
> I guess. At first I thought we can't do that before inspecting
> rollups,
> which only happens later in the function, but now I see there's
> aggstrategy in GroupingSetsPath too.
Looks good.
Jeff
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martín Marqués | 2020-05-29 20:39:31 | Re: Read access for pg_monitor to pg_replication_origin_status view |
| Previous Message | Tom Lane | 2020-05-29 19:47:06 | Re: pie-in-sky idea: 'sensitive' function parameters |