| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Raúl Marín Rodríguez <rmrodriguez(at)carto(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |
| Date: | 2019-01-21 16:10:22 |
| Message-ID: | 31298.1548087022@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> Perhaps it would be OK we changed back the glob line to use $prefix
> instead of $qprefix, but kept the use of $qprefix in the later regex.
Well, glob does have some metacharacters, so not doing any quoting
at all still leaves us with failure modes.
I did a little bit of googling on this subject last night, and it
seems that at least some people believe that the answer is to not
use glob, period, but read the directory for yourself. Maybe there's
a better way, but the breakage around backslashes doesn't really
leave me hopeful.
As a short-term move to un-break the buildfarm, I'm just going to
revert that patch altogether. We can reapply it once we've
figured out how to do the glob part correctly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-01-21 16:11:34 | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |
| Previous Message | Andrew Dunstan | 2019-01-21 15:40:47 | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |