From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. |
Date: | 2022-09-15 04:48:22 |
Message-ID: | 3122568.1663217302@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> We seem to be maintaining old code in pg_upgrade to not break it, see
> [3]. I can think of a fix [4] or just [5], it may not be great to do
> these kinds of fixes for all the pg_resetwal output changes. Since the
> changes we make to the output formats of controlfile or pg_resetwal
> are very rare, any of [4] or [5] looks good to me and it is better
> than backporting [2] IMO.
Yeah, the lowest-tech solution is to accept either spelling of
the description string. But I'm not very happy with the whole
approach right now. We should have an implementation that isn't
dependent on how user-friendly strings are spelled. (git seems
a bit ahead of us here, with its distinction between "plumbing"
and "porcelain" operations.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-09-15 04:50:07 | Re: pgsql: Move gramparse.h to src/backend/parser |
Previous Message | John Naylor | 2022-09-15 04:45:30 | pgsql: Fix grammar in error message |