| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Ajit Awekar <ajit(dot)awekar(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rushabh Lathia <rushabh(dot)lathia(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Subject: | Re: Memory leak in CachememoryContext |
| Date: | 2023-04-24 17:03:27 |
| Message-ID: | 312097.1682355807@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2023-Apr-24, Tom Lane wrote:
>> I guess we could have the back branches continue to create a
>> shared_cast_context and just not use it in core. Seems rather
>> expensive for a very hypothetical compatibility measure, though.
> I think a session-long memory leak is not so bad, compared to a possible
> crash. However, after looking at the code again, as well as pldebugger
> and plpgsql_check, I agree that there's no point in doing anything other
> than keeping the field there.
Yeah, I can't see any plausible reason for outside code to be using
that field (and I don't see any evidence in Debian Code Search that
anyone is). I'll push it like this then. Thanks for looking!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mat Arye | 2023-04-24 17:06:24 | Re: [PATCH] Support % wildcard in extension upgrade filenames |
| Previous Message | Nathan Bossart | 2023-04-24 16:52:21 | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands |