| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Date: | 2025-02-23 23:45:32 |
| Message-ID: | 3116E7C6-3580-49FC-899F-5E4727DB6CFA@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> IMO, the set of cases where it's legitimate to mark individual struct
>> fields as const is negligibly small, and this doesn't seem to be one
>> of them.
>
> Thanks for the report, will fix.
>
>> BTW, as another nitpicky style matter: why do PGoauthBearerRequest
>> etc. spell their struct tag names differently from their typedef names
>> (that is, with/without an underscore)? That is not our project style
>> anywhere else, and I'm failing to detect a good reason to do it here.
>
> Indeed it isn't, the only explanation is that I missed it. Will fix.
The attached diff passes CI and works for me, will revisit in the morning.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| structfixups.diff | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-24 00:19:09 | Re: Missing [NO] INDENT flag in XMLSerialize backward parsing |
| Previous Message | Greg Sabino Mullane | 2025-02-23 23:30:36 | Re: psql \dh: List High-Level (Root) Tables and Indexes |