From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Add documentation for the JIT feature. |
Date: | 2018-03-31 15:43:37 |
Message-ID: | 31150.1522511017@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 3/29/18 14:43, Alvaro Herrera wrote:
>>> Hm, what's wrong just doing it in the normal build? It's a desired build
>>> artifact, so I really don't see any argument for not building it by
>>> default? Don't quite see what the advantage of doing it during make
>>> check would be?
>> I meant running something that would check that the file compiles,
>> without actually producing the output. For the regular docs, there's a
>> couple of orders of magnitude of difference in time to do the check vs.
>> the actual build.
> Or we do both.
I'm OK with adding INSTALL to the default build target in doc/src/sgml;
the incremental cost isn't large and we now realize there'd be useful
error detection. I'm *not* OK with expanding the scope of "make check"
to include building the documentation. It's never had anything to do
with docs before and I see no reason to start now. Personally, when
I'm working on a patch, the doc updates if any are a completely separate
matter. I don't want to waste cycles on testing docs when I'm trying
to test code, any more than I would like the reverse (ie forcing a docs
build to build code too).
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-31 15:46:18 | Re: pgsql: Add documentation for the JIT feature. |
Previous Message | Peter Eisentraut | 2018-03-31 15:32:01 | Re: pgsql: Add documentation for the JIT feature. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2018-03-31 15:46:18 | Re: pgsql: Add documentation for the JIT feature. |
Previous Message | Alvaro Herrera | 2018-03-31 15:41:32 | Re: [HACKERS] Runtime Partition Pruning |