| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | michael(dot)paquier(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c. |
| Date: | 2016-03-29 13:48:32 |
| Message-ID: | 31133.1459259312@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Christian Ullrich <chris(at)chrullrich(dot)net> writes:
> Anyway, I think Michael's fix is wrong. The bug is that the Win32
> version of link() (at the bottom of zic.c) does not set errno if its
> attempt to copy the file fails, so what dolink() puts into link_errno is
> bogus.
Ah-hah, that explains things nicely. The previous coding in dolink()
wasn't so dependent on link() returning a valid errno on failure.
> Patch attached.
But then, should not this code make sure that errno *always* gets set?
I'd be inclined to think we should use _dosmaperr(), too, rather than
hand-coding it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Ullrich | 2016-03-29 14:11:42 | Re: [COMMITTERS] pgsql: Sync tzload() and tzparse() APIs with IANA release tzcode2016c. |
| Previous Message | Robert Haas | 2016-03-29 10:32:32 | Re: [COMMITTERS] pgsql: pgbench: Support double constants and functions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-03-29 13:56:30 | Re: PoC: Partial sort |
| Previous Message | David Steele | 2016-03-29 13:48:27 | Re: improving GROUP BY estimation |