| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aidan Van Dyk <aidan(at)highrise(dot)ca> |
| Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Chris Browne <cbbrowne(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Lessons from commit fest |
| Date: | 2008-04-18 00:47:12 |
| Message-ID: | 3113.1208479632@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aidan Van Dyk <aidan(at)highrise(dot)ca> writes:
> * Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> [080417 20:11]:
>> Ouch, that's a real good point. Maybe a certain amount of platform
>> dependence is inevitable.
> I don't get it. If they are used as typedefs *anywhere* in the PG
> source, they're needed in the typedef list.
Right, but if the only use is inside #ifdef __BRAND_X_PLATFORM__,
the only way for the proposed toolchain to extract that usage is
if someone runs it on BRAND_X_PLATFORM.
Of course, for seldom-used platforms maybe we don't care that much.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-18 00:49:22 | Re: Proposed patch - psql wraps at window width |
| Previous Message | Gregory Stark | 2008-04-18 00:42:26 | Re: Proposed patch - psql wraps at window width |