Re: REINDEX and shared catalogs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: REINDEX and shared catalogs
Date: 2018-08-08 18:39:00
Message-ID: 31117.1533753540@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2018-Aug-05, Michael Paquier wrote:
>> Attached is a set of patches I proposed on the original thread, which
>> skips shared catalogs if the user running REINDEX is not an owner of
>> it. This is a behavior change, and as I have a hard time believing that
>> anybody can take advantage of the current situation, I would like also
>> to see this stuff back-patched, as anybody doing shared hosting of
>> Postgres is most likely fixing the hole one way or another. However, I
>> am sure as well that many folks here would not like that.

> I agree that it would be good to have it fixed in released versions, but
> I also agree that such a change could cause trouble in production for
> some. Is the "no backpatch" idea that you will push this to both pg11
> and master? That would get my vote.

Same here. I am not excited about putting such a change into stable
branches, mainly because the existing behavior has been there for
twenty years without any previous complaints. So it's not *that* big
a problem. But it's not too late for v11, I think.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-08-08 18:49:05 Re: Fix hints on CREATE PROCEDURE errors
Previous Message Alvaro Herrera 2018-08-08 18:28:20 Re: REINDEX and shared catalogs