Re: pgsql: Remove --disable-spinlocks.

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove --disable-spinlocks.
Date: 2024-07-30 11:09:42
Message-ID: 310f4005-91d7-42b2-ac70-92624260dd28@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 30/07/2024 14:03, Thomas Munro wrote:
> Remove --disable-spinlocks.

Sorry, spotted this only now:

> --- a/src/backend/postmaster/launch_backend.c
> +++ b/src/backend/postmaster/launch_backend.c
> @@ -108,9 +108,7 @@ typedef struct
> #ifdef USE_INJECTION_POINTS
> struct InjectionPointsCtl *ActiveInjectionPoints;
> #endif
> -#ifndef HAVE_SPINLOCKS
> PGSemaphore *SpinlockSemaArray;
> -#endif
> int NamedLWLockTrancheRequests;
> NamedLWLockTranche *NamedLWLockTrancheArray;
> LWLockPadded *MainLWLockArray;

The SpinLockSemaArray field should be completely completely, nut just
the #ifndef guard around it.

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2024-07-30 11:18:54 pgsql: Remove useless member of BackendParameters.
Previous Message Thomas Munro 2024-07-30 11:03:37 pgsql: Require compiler barrier support.