| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, david(at)pgmasters(dot)net, Peter Eisentraut <peter(at)eisentraut(dot)org>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logging which local address was connected to in log_line_prefix |
| Date: | 2025-04-06 22:53:14 |
| Message-ID: | 3105945.1743979994@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I'd suggest the addition of this data to csvlog.c and jsonlog.c,
> perhaps only adding this information if local_host[0] is not '\0'
> rather than assigning a default "[none]" all the time to save some
> space in the entries generated.
I think that's completely impractical for csvlog: changing the row
type for CSV output is a serious compatibility break, and there is
exactly zero evidence that the local address info is worth that.
JSON has less of a compatibility problem, but I still doubt that
the local address info is worth the space it'd take, for about
99% of users. Also note that we have no good way for the user
to specify what fields she wants in jsonlog, otherwise we could
make it appear only if asked for.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-04-06 23:04:29 | Re: [PoC] Reducing planning time when tables have many partitions |
| Previous Message | Daniel Gustafsson | 2025-04-06 22:50:54 | Re: History doc page clarification on naming |