Re: [BUGS] object_classes array is broken, again

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Jaimin Pan <jaimin(dot)pan(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [BUGS] object_classes array is broken, again
Date: 2015-07-20 17:48:48
Message-ID: 31003.1437414528@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

I wrote:
> +1 to this patch, in fact I think we could remove MAX_OCLASS altogether
> which would be very nice for switch purposes.

Oh, wait, I forgot that the patch itself introduces another reference to
MAX_OCLASS. I wonder though if we should get rid of that as an enum value
in favor of #define'ing a LAST_OCLASS macro referencing the last enum
item, or some other trick like that. It's certainly inconvenient in
event_trigger.c to have a phony member of the enum.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message dsrich 2015-07-21 00:39:29 BUG #13507: INSERT into tables with SERIAL primary keys failing about half of the time
Previous Message Tom Lane 2015-07-20 17:44:58 Re: BUG #13506: jsonb || operator does not work

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2015-07-20 18:28:55 Re: First Aggregate Funtion?
Previous Message Tom Lane 2015-07-20 16:59:41 Re: [HACKERS] object_classes array is broken, again