Re: simplehash.h comment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: simplehash.h comment
Date: 2018-08-27 13:40:54
Message-ID: 31002.1535377254@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> ... and a patch. Thoughts?

It's not real obvious why you're adding inclusion guards over just a
subset of the header. A short comment about that would be worthwhile.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2018-08-27 13:55:18 Re: Built-in connection pooling
Previous Message Stephen Frost 2018-08-27 13:35:21 Re: pg_dump test instability