Re: KNNGiST for knn-search (WIP)

From: Paul Ramsey <pramsey(at)cleverelephant(dot)ca>
To: Greg Stark <gsstark(at)mit(dot)edu>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: KNNGiST for knn-search (WIP)
Date: 2010-01-04 22:33:25
Message-ID: 30fe546d1001041433x7e6c9227r9140c953abb29980@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm sure whatever conclusion -hackers comes to in the end will be the
best for pgsql, and I'll be supportive. But until then, let me note
from the PostGIS point-of-view: sure would be great to get this in for
8.5 :)

P.

On Thu, Dec 31, 2009 at 4:26 AM, Greg Stark <gsstark(at)mit(dot)edu> wrote:
> On Wed, Dec 30, 2009 at 4:56 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> From my point of view, what makes a patch invasive is the likelihood
>> that it might break something other than itself.  For example, your
>> patch touches the core planner code and the core GIST code, so it
>> seems possible that adding support for this feature might break
>> something else in one of those areas.
>
> It doesn't seem obvious to me that this is a high-risk patch. It's
> touching the planner which is tricky but it's not the kind of massive
> overhaul that touches every module that HOT or HS were.  I'm really
> glad HS got in before the end because lots of people with different
> areas of expertise and different use cases are going to get to
> exercise it in the time remaining. This patch I would expect
> relatively few people to need to try it out before any oversights are
> caught.
>
> --
> greg
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-01-04 23:02:18 Re: KNNGiST for knn-search (WIP)
Previous Message Bruce Momjian 2010-01-04 22:14:00 Re: pg_migrator issues