Re: Remove useless associativity/precedence from parsers

On 5/21/19 11:49 AM, Akim Demaille wrote:
> Hi Tom!
>
>> Le 20 mai 2019 à 15:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> a écrit :
>>
>> Akim Demaille <akim(at)lrde(dot)epita(dot)fr> writes:
>>> It is for the same reasons that I would recommend not using associativity directives (%left, %right, %nonassoc) where associativity plays no role: %precedence is made for this. But it was introduced in Bison 2.7.1 (2013-04-15), and I don't know if requiring it is acceptable to PostgreSQL.
>> 2013? Certainly not. We have a lot of buildfarm critters running
>> older platforms than that.
> This I fully understand. However, Bison is a source generator,
> and it's quite customary to use modern tools on the maintainer
> side, and then deploy the result them on possibly much older
> architectures.
>
> Usually users of Bison build tarballs with the generated parsers
> in them, and ship/test from that.
>

The buildfarm client does not build from tarballs, it builds from git,
meaning it has to run bison. Thus Tom's objection is quite valid, and
your dismissal of it is not.

cheers

andrew

--

Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services