Re: pgsql: Add support for temporary replication slots

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for temporary replication slots
Date: 2016-12-15 08:46:27
Message-ID: 309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 14/12/16 15:35, Peter Eisentraut wrote:
> On 12/12/16 8:28 PM, Petr Jelinek wrote:
>> On 13/12/16 02:00, Andres Freund wrote:
>>> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote:
>>>> I mentioned that as possible solution upthread, I am only worried that
>>>> the failure scenario is basically infinite loop.
>>>
>>> I don't see the problem with that. If you're really concerned you can
>>> set a statement timeout.
>>>
>>
>> Okay in case we decide it's the right way to go attached patch does
>> that. I also added some more tests based on your feedback while I am at it.
>
> This looks mostly reasonable to me, but the location and xid output from
> pg_logical_slot_get_changes() is not portable/repeatable, so it should
> be omitted from the output.
>

Sigh, yes you are right.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Various-temporary-slots-test-improvements.patch text/x-diff 6.9 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Law 2016-12-15 09:30:17 Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default
Previous Message Peter Eisentraut 2016-12-14 14:35:23 Re: pgsql: Add support for temporary replication slots

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2016-12-15 09:04:37 pg_basebackups and slots
Previous Message Magnus Hagander 2016-12-15 08:44:15 Crash on promotion when recovery.conf is renamed