| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add tests for '-f' option in dropdb utility. |
| Date: | 2019-11-28 14:46:09 |
| Message-ID: | 30914.1574952369@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> The message expected by this test was: "FATAL: terminating connection
> due to administrator command" which seems to be fine in most cases but
> not all.
I think the correct question to ask is "why not all cases"?
> I think we just need to change the expected message the same as in
> 013_crash_restart.pl to make this test pass on all platforms.
If DROP FORCE sometimes gives victim sessions the impression that the
server crashed, rather than that they were kicked off intentionally,
I think that's totally unacceptable. "Fixing" this by changing the
test to allow it is not the answer, and if we can't find a better
answer, I'm going to vote to revert the feature.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-11-28 15:43:19 | Re: pgsql: Add tests for '-f' option in dropdb utility. |
| Previous Message | Amit Kapila | 2019-11-28 13:49:48 | Re: pgsql: Add tests for '-f' option in dropdb utility. |