Re: pgsql: Refactor script execution state machine in pgbench.

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Refactor script execution state machine in pgbench.

There's at least one bug in this patch. It's caused pgbench to go into an
infinite loop during the TAP tests on my buildfarm machine longfin.

$ ps auxww | grep buildfarm | grep pgbench
buildfarm 9033 100.0 0.1 2462896 5936 ?? R 4:06AM 719:14.18 /Users/buildfarm/bf-data/HEAD/inst/bin/pgbench --no-vacuum --client=5 --protocol=prepared --transactions=25 --file /Users/buildfarm/bf-data/HEAD/pgsql.build/src/bin/pgbench/tmp_check/data_main_JNh2/pgbench_script
buildfarm 9023 0.0 0.2 2603480 18696 ?? S 4:06AM 0:00.34 /Users/buildfarm/bf-data/HEAD/inst/bin/postgres -D /Users/buildfarm/bf-data/HEAD/pgsql.build/src/bin/pgbench/tmp_check/data_main_JNh2/pgdata
buildfarm 9009 0.0 0.1 2458948 12224 ?? S 4:06AM 0:04.56 /usr/bin/perl t/001_pgbench.pl
buildfarm 9007 0.0 0.0 2433396 2220 ?? S 4:06AM 0:00.00 /bin/sh -c cd . && TESTDIR='/Users/buildfarm/bf-data/HEAD/pgsql.build/src/bin/pgbench' PATH="/Users/buildfarm/bf-data/HEAD/inst/bin:$PATH" PGPORT='65678' top_builddir='/Users/buildfarm/bf-data/HEAD/pgsql.build/src/bin/pgbench/../../..' PG_REGRESS='/Users/buildfarm/bf-data/HEAD/pgsql.build/src/bin/pgbench/../../../src/test/regress/pg_regress' prove -I ../../../src/test/perl/ --verbose t/*.pl
buildfarm 9002 0.0 0.0 2432936 2108 ?? S 4:06AM 0:00.01 /Applications/Xcode.app/Contents/Developer/usr/bin/make -C pgbench installcheck

Some other buildfarm critters seem to have got through that successfully,
so it's probably a portability issue not a hard failure.

regards, tom lane