Re: pgsql: Reduce running time of jsonb_sqljson test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Reduce running time of jsonb_sqljson test
Date: 2022-04-06 15:20:02
Message-ID: 3084516.1649258402@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The test created a 1m row table in order to test parallel operation of
> JSON_VALUE.

Egad.

> However, this was more than were needed for the test, so
> save time by halving it, and also by making the table unlogged.

This seems like a rather inappropriate fix. I would say that a test
of this size does not belong in the core regression tests AT ALL.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-06 17:24:54 pgsql: Allow granting SET and ALTER SYSTEM privileges on GUC parameters
Previous Message Andrew Dunstan 2022-04-06 14:30:45 pgsql: Reduce running time of jsonb_sqljson test