Re: typo in doc for "Miscellaneous Coding Conventions"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: tanghy(dot)fnst(at)fujitsu(dot)com
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: typo in doc for "Miscellaneous Coding Conventions"
Date: 2021-05-18 13:52:27
Message-ID: 3079730.1621345947@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

PG Doc comments form <noreply(at)postgresql(dot)org> writes:
> small fix in description at [1] as follows

> -If that were not done interrupted code that's currently inspecting errno
> might see the wrong value.
> +If that was not done interrupted code that's currently inspecting errno
> might see the wrong value.

The existing text is perfectly good English; your change
makes it less so. I'm afraid it's been too many years since
high school English for me to remember the exact grammatical
term for this, but "were not" is typical usage when stating
a contrary-to-fact hypothetical.

regards, tom lane

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bryn Llewellyn 2021-05-18 16:26:25 Re: typo in doc for "Miscellaneous Coding Conventions"
Previous Message Jonathan S. Katz 2021-05-18 13:26:24 Re: pgpool: APPARENT DEADLOCK!!! Complete Status: Managed Threads: 3 Active Threads: 3