Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

On Fri, Oct 31, 2008 at 7:42 PM, Emmanuel Cecchet <manu(at)frogthinker(dot)org> wrote:
> Hi Nikhil,
>

i'm looking at this one:
http://archives.postgresql.org/message-id/a301bfd90810310750pf108c69x36499546f406650f@mail.gmail.com

> Here are a couple of questions:
> - How do you ALTER the table to repartition it?

fair question. but the patch was advertized to only automate some
tasks that we do manually... so keeping the same limitations seems
reasonably to me...

> - Another option is to have a separate trigger per child table and chain
> them to the master table. For example something like:

that sounds like a lot of overhead...

---------------

Now, about the patch...

- seems strange the need to create plpgsql language before we can
create any partitioned table but given that the trigger is a plpgsql
function (and a c function can't be used because we could need to add
new partitions) it seems necesary... ideas?

- the update part of the trigger looks very simplistic... if the new
values isn't in the range accepted by the partition it errors out
because of the check constraint... can't we be a little smarter,
delete from the actual partition and insert in the new one...

for the rest, the patch passes all regression tests and seems to work
as advertized....

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157