Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Huge +1 for cleaning up this abuse of caseValue_datum/domainValue_datum.
> While correct and sensible if we continue the abuse, these patches feel
> like putting lipstick on a pig.
Agreed. I spent some time trying to do it better, with results
shown at [1]. If we adopt that idea, then the executor's support
for CaseTestExpr will go away, so there's little point in pursuing
that half of the patch given here. However, I concluded that there's
insufficient reason to redesign CoerceToDomainValue, so we could
still push forward with that half of this patch.
regards, tom lane
[1] https://www.postgresql.org/message-id/3068812.1738206654@sss.pgh.pa.us