| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Zero-padding and zero-masking fixes for to_char(float) |
| Date: | 2015-03-22 05:42:56 |
| Message-ID: | 30701.1427002976@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> This seems to have broken jacana. Looks like MSVC by default has a 3 digit
> exponent.
jacana was broken before this patch; but some other Windows critters
are now unhappy as well.
> Going by this:
> https://msdn.microsoft.com/en-us/library/0fatw238(v=vs.80).aspx it seems
> that it can quite easily be set back to 2.
> I've attached a patch which seems to fix the issue.
That seems likely to have side-effects far beyond what's appropriate.
We have gone out of our way to accommodate 3-digit exponents in other
tests. What I want to know is why this patch created a 3-digit output
where there was none before.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-03-22 06:11:22 | Re: proposal: searching in array function - array_position |
| Previous Message | David Rowley | 2015-03-22 05:27:10 | Re: Using 128-bit integers for sum, avg and statistics aggregates |