Re: pgsql: Fix WAL replay of locking an updated tuple

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix WAL replay of locking an updated tuple
Date: 2014-02-27 14:41:03
Message-ID: 30633.1393512063@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Fix WAL replay of locking an updated tuple

The test added by this patch certainly looks like it's backwards.
Shouldn't you be clearing HOT_UPDATED only if the tuple is *not*
XMAX_IS_LOCKED_ONLY?

If the code is actually correct as written, then I think that test
macro is very unfortunately named.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-02-27 14:43:18 pgsql: doc: bgw_main takes a Datum argument, not void *.
Previous Message Alvaro Herrera 2014-02-27 14:32:03 pgsql: Fix WAL replay of locking an updated tuple