Re: pgsql: Disallow newlines in parameter values to be set in ALTER SYSTEM.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: obartunov(at)gmail(dot)com
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Disallow newlines in parameter values to be set in ALTER SYSTEM.
Date: 2016-04-05 20:02:55
Message-ID: 30584.1459886575@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Oleg Bartunov <obartunov(at)gmail(dot)com> writes:
> On Tue, Apr 5, 2016 at 9:05 AM, Oleg Bartunov <obartunov(at)gmail(dot)com> wrote:
>> it's also fixed problem with setting parameter to ''. Before
>> alter system SET shared_preload_libraries = '';

> Ooops, it doesn't :(
> FATAL: could not access file "": No such file or directory

> cat /usr/local/pgsql-head/data/postgresql.auto.conf
> # Do not edit this file manually!
> # It will be overwritten by ALTER SYSTEM command.
> shared_preload_libraries = '""'

I do not think this is a bug, or at least not an ALTER SYSTEM bug.
What you wrote there means a single list entry that is an empty string,
and ALTER SYSTEM reproduced that faithfully.

We do have a shortcoming here, which is that the SET syntax lacks any
way to explicitly set a GUC_LIST_INPUT variable to an empty list.
It's been like that for a long time with few complaints, but maybe
we should do something about it.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-04-05 20:09:05 pgsql: Fix parallel-safety code for parallel aggregation.
Previous Message Robert Haas 2016-04-05 19:48:22 Re: [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche.