Re: BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pm91(dot)arapov(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL
Date: 2025-03-14 14:27:07
Message-ID: 3055350.1741962427@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> Looks like there is inconsistency with 'ind_name' and 'int_type' checks. In
> one place both are checked. In other place only the second one is checked.
> It's possible that when the second is not NULL the first is also not NULL.
> If this is so then the problem is not real. But it's hard to prove this. In
> any case the code needs to be made more clear.

Perhaps it needs to be made more clear, but this patch seems like no
improvement. Adding that Assert accomplishes nothing --- the code
will dump core if ind_name is null, with or without an Assert.

Given the lack of field complaints, I'm inclined to believe there's
not a bug here.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Viktor Holmberg 2025-03-14 14:28:01 Re: ISN extension - wrong volatility level for isn_weak() function
Previous Message Tom Lane 2025-03-14 14:16:24 Re: ISN extension - wrong volatility level for isn_weak() function