Re: BUG #18848: DEREF_AFTER_NULL.EX.COND After having been compared to a NULL

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> Looks like there is inconsistency with 'ind_name' and 'int_type' checks. In
> one place both are checked. In other place only the second one is checked.
> It's possible that when the second is not NULL the first is also not NULL.
> If this is so then the problem is not real. But it's hard to prove this. In
> any case the code needs to be made more clear.

Perhaps it needs to be made more clear, but this patch seems like no
improvement. Adding that Assert accomplishes nothing --- the code
will dump core if ind_name is null, with or without an Assert.

Given the lack of field complaints, I'm inclined to believe there's
not a bug here.

regards, tom lane