Re: Unfortunate choice of short switch name in pgbench

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unfortunate choice of short switch name in pgbench
Date: 2014-02-27 14:36:33
Message-ID: 30512.1393511793@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Fabien COELHO wrote:
>>> I just wasted some time puzzling over strange results from pgbench.
>>> I eventually realized that I'd been testing against the wrong server,
>>> because rather than "-p 65432" I'd typed "-P 65432", thereby invoking
>>> the recently added --progress option. pgbench has no way to know that
>>> that isn't what I meant; the fact that both switches take integer
>>> arguments doesn't help.

>> ISTM that this is an unfortunate but unlikely mistake, as "-p" is
>> used in all postgresql commands to signify the port number (psql,
>> pg_dump, pg_basebackup, createdb, ...).

> Plus other tools already use -P for progress, such as rsync.

Yeah, but they don't make -P take an integer argument. It's that
little frammish that makes this problem significant.

I don't object to having the --progress switch. I just think we
could live without a short form for it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2014-02-27 14:51:38 Re: UNION ALL on partitioned tables won't use indices.
Previous Message Alvaro Herrera 2014-02-27 14:34:36 Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem?