| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Noah Misch <noah(at)leadboat(dot)com>, Jeff Davis <jdavis(at)postgresql(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add contrib/pg_walinspect. |
| Date: | 2022-04-27 03:15:40 |
| Message-ID: | 304865.1651029340@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> BTW If you had your local change from debug.patch (upthread), that'd
>> defeat the patch. I mean this:
>> + if(!*errormsg)
>> + *errormsg = "decode_queue_head is null";
> Oh! Okay, I'll retry without that.
I've now done several runs with your patch and not seen the test failure.
However, I think we ought to rethink this API a bit rather than just
apply the patch as-is. Even if it were documented, relying on
errormsg = NULL to mean something doesn't seem like a great plan.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-04-27 03:27:23 | Re: pgsql: Add contrib/pg_walinspect. |
| Previous Message | Tom Lane | 2022-04-27 02:15:16 | Re: pgsql: Add contrib/pg_walinspect. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-04-27 03:26:09 | Re: Possible corruption by CreateRestartPoint at promotion |
| Previous Message | Michael Paquier | 2022-04-27 03:00:49 | Re: Fix primary crash continually with invalid checkpoint after promote |