| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: suspicious valgrind reports about radixtree/tidstore on arm64 |
| Date: | 2024-06-20 08:01:03 |
| Message-ID: | 304198.1718870463@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> On Thu, Jun 20, 2024 at 8:12 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> IIUC there is no particular reason for the current order in RT_NODE_48.
> Yeah. I found that simply swapping them enables clang to avoid
> double-initialization, but gcc still can't figure it out and must be
> told to stop at slot_idxs[]. I'd prefer to do it that way and document
> that slot_idxs is purposefully the last member of the fixed part of
> the struct.
WFM.
> If that's agreeable I'll commit it that way tomorrow
> unless someone beats me to it.
I was going to push it, but feel free.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2024-06-20 08:30:45 | Re: [HACKERS] make async slave to wait for lsn to be replayed |
| Previous Message | John Naylor | 2024-06-20 07:58:28 | Re: suspicious valgrind reports about radixtree/tidstore on arm64 |