| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | pgtranslation-translators <pgtranslation-tanslators(at)pgfoundry(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: filenames in pg_basebackup |
| Date: | 2012-07-25 20:25:36 |
| Message-ID: | 3026.1343247936@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I notice that pg_basebackup has lots of messages where file names are
> not in quotes. Is this okay?
They should be in double quotes, per our message style guidelines.
> msgid "%s: segment file '%s' is incorrect size %d, skipping\n"
> I also wonder about "is" vs. "has" in the above message.
Yeah, "has" would be more correct.
> Apparently, this needs a thorough revision ...
Evidently. Peter tends to see to that sort of thing while he works on
translations, but I'm sure he wouldn't mind some help.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-25 20:30:10 | Re: Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2) |
| Previous Message | Tom Lane | 2012-07-25 20:09:42 | Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2) |