| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: speed up unicode normalization quick check |
| Date: | 2020-10-19 14:38:43 |
| Message-ID: | 302500.1603118323@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> On Mon, Oct 19, 2020 at 2:16 AM Peter Eisentraut <
> peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> Could you adjust the generation script so that the resulting header file
>> passes the git whitespace check? Check the output of
>> git show --check 80f8eb79e24d9b7963eaf17ce846667e2c6b6e6f
> My git manual says:
> ...
> The above would mean we should have errors for every function whose
> parameters are lined with the opening paren, so I don't see why it would
> fire in this case. Is the manual backwards?
Probably not, but our whitespace rules are not git's default.
See .gitattributes at the top level of a git checkout.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | bucoo@sohu.com | 2020-10-19 14:42:57 | parallel distinct union and aggregate support patch |
| Previous Message | John Naylor | 2020-10-19 14:36:00 | Re: speed up unicode decomposition and recomposition |