From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |
Date: | 2019-03-01 19:29:13 |
Message-ID: | 30177.1551468553@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-03-01 14:17:33 -0500, Tom Lane wrote:
>> I think we should reject the whole patch, tbh, and go do something
>> about the underlying problem instead. Once we've made truncation
>> not require AEL, this will be nothing but a legacy wart that we'll
>> have a hard time getting rid of.
> IDK, it's really painful in the field, and I'm not quite seeing us
> getting rid of the AEL for v12.
Dunno, I was musing about it just yesterday, in
https://postgr.es/m/1261.1551392263@sss.pgh.pa.us
I'd sure rather spend time making that happen than this. I'm also
not entirely convinced that we MUST do something about this in v12
rather than v13 --- we've been living with it ever since we had
in-core replication, why's it suddenly so critical?
> I think it's a wart, but one that works
> around a pretty important usability issue. And I think we should just
> remove the GUC without any sort of deprecation afterwards, if necessary
> we can add a note to the docs to that effect. It's not like preventing
> truncation from happening is a very intrusive / dangerous thing to do.
Well, if we add a reloption then we can never ever get rid of it; at
best we could ignore it. So from the perspective of how-fast-can-we-
deprecate-this, maybe a GUC is the better answer. On the other hand,
I'm not sure I believe that many installations could afford to disable
truncation for every single table.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-03-01 19:34:18 | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |
Previous Message | Andrew Dunstan | 2019-03-01 19:26:44 | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |