| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | David Rowley <drowley(at)postgresql(dot)org>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: jsonb crash |
| Date: | 2021-09-29 21:09:48 |
| Message-ID: | 3001998.1632949788@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 30 Sept 2021 at 09:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> After further inspection, "what are we doing in jsonb_hash?" is
>> indeed a relevant question, but it seems like it's a type mismatch
>> not a nullness issue. EXPLAIN VERBOSE shows
> I think you're right here. It should be hashing text. That seems to
> be going wrong in check_memoizable() because it assumes it's always
> fine to use the left side's type of the OpExpr to figure out the hash
> function to use.
> Maybe we can cache the left and the right type's hash function and use
> the correct one in paraminfo_get_equal_hashops().
Um ... it seems to have correctly identified the cache key expressions,
so why isn't it just doing exprType on those? The jsonb_exists operator
seems entirely irrelevant here.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-29 21:12:45 | Re: when the startup process doesn't (logging startup delays) |
| Previous Message | Andrew Dunstan | 2021-09-29 21:04:48 | Re: prevent immature WAL streaming |