| From: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, Martin Renters <martin(at)datafax(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: beta6 pg_restore core dumps |
| Date: | 2001-03-18 01:46:36 |
| Message-ID: | 3.0.5.32.20010318124636.02ad9c20@mail.rhyme.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 12:31 17/03/01 -0500, Tom Lane wrote:
>
>This would be a lot simpler and cleaner if _PrintData() simply didn't
>append a zero byte to the buffer contents. Philip, is it actually
>necessary for it to do that?
>
Strictly, I think the answer is that it is not necessary. The output of the
uncompress may be a string, which could be passed to one of the str*
functions by a downstream call. AFAICT, this is not the case, and the code
should work without it, but it's probably safer in the long run to leave it
there. If you have strong feelings about removing it, I'll have a closer
look at the code, but my guess is that it was just me being paranoid (and
stuffing up).
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2001-03-18 01:57:49 | Re: beta6 pg_restore core dumps |
| Previous Message | Tatsuo Ishii | 2001-03-18 01:13:59 | Re: beta6 pg_restore core dumps |