Suggested fix for pg_dump

The problem with pg_dump and renamed primary key attrs can be fixed by
using the indkey attribute of pg_index to lookup attrs in pg_class - this
is what pg_dump does when it dumps indexes. If I am going to make this
change, I would also like to split the PK definition out from the table
definition, so we would have:

Create Table fred(f1 int);
Alter Table fred add constraint primary key(f1);

instead of:

Create Table fred(f1 int, primary key(f1));

The reason for this is that it will improve load performance, and begin to
allow pg_restore to separate constraints from tables.

Is this OK? Or inappropriate for beta?

Needless to say, I don't really want to revisit this piece of code in 3
months time, so I'd like to do it now.

----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/