| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: list of extended statistics on psql |
| Date: | 2021-01-06 23:09:04 |
| Message-ID: | 2fe425ac-dc47-f304-c8d7-9fea763482d7@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/5/21 5:26 AM, Tatsuro Yamada wrote:
> Hi,
>
>> I rebased the patch set on the master (7e5e1bba03), and the regression
>> test is good. Therefore, I changed the status of the patch: "needs
>> review".
>
> Happy New Year!
>
> I rebased my patches on HEAD.
> Please find attached files. :-D
>
Thanks, and Happy new year to you too.
I almost pushed this, but I have one more question. listExtendedStats
first checks the server version, and errors out for pre-10 servers.
Shouldn't the logic building query check the server version too, to
decide whether to check the MCV stats? Otherwise it won't work on 10 and
11, which does not support the "mcv" stats.
I don't recall what exactly is our policy regarding new psql with older
server versions, but it seems strange to check for 10.0 and then fail
anyway for "supported" versions.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-01-06 23:43:09 | Re: Parallel Inserts in CREATE TABLE AS |
| Previous Message | Peter Geoghegan | 2021-01-06 22:02:05 | Re: data_checksums enabled by default (was: Move --data-checksums to common options in initdb --help) |