| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr>, Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Subject: | Re: Add header support to text format and matching feature |
| Date: | 2022-06-13 07:35:16 |
| Message-ID: | 2fa8b595-62e6-49db-02aa-a01e2455ba79@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.06.22 04:32, Julien Rouhaud wrote:
>> I think it makes more sense to have a sanity check to prevent HEADER
>> MATCH with COPY TO.
>
> I'm fine with it. I added such a check and mentioned it in the documentation.
> I think it would still be problematic if the target table has dropped columns.
> Fortunately, as I initially thought the problem is only due to a thinko in the
> original commit which used a wrong variable for the raw_fields offset. Once
> fixed (attached v1) I didn't see any other problem in the rest of the logic and
> all the added regression tests work as expected.
Thanks for this patch. I'll check it in detail in a bit. It looks good
to me at first glance.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-06-13 07:46:46 | Re: Add header support to text format and matching feature |
| Previous Message | houzj.fnst@fujitsu.com | 2022-06-13 07:33:18 | RE: Replica Identity check of partition table on subscriber |